feat(react): update to support react 17 #1563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scurker
changed the title
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
scurker
commented
Jul 3, 2024
| @@ -515,6 +515,9 @@ test('should prevent default with enter keypress and open listbox', () => { | |||
| // rtl doesn't let us mock preventDefault | |||
| // see: https://github.com/testing-library/react-testing-library/issues/572 | |||
| event.preventDefault = preventDefault; | |||
| if (type === 'focus') { | |||
There was a problem hiding this comment.
The changes here I suspect are related to testing-library/user-event#592, but we're not using user-event but are calling fireEvent due to specific limitations with testing library.
|
Also closes #1473 |
AHHHHHHH auto completion got me and I didn't check the ticket that this one was supposed to close 😅 |
anastasialanz
force-pushed
the
react-17
branch
3 times, most recently
from
ae83efa
to
e4d12af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1473
The
Modalcomponent works fine with the Cauldron 17 upgrade.modal-component.mov
TODO: